Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 Removes the multiple indicator from Solr suffix #2341

Merged
merged 2 commits into from
Sep 20, 2024
Merged

💄 Removes the multiple indicator from Solr suffix #2341

merged 2 commits into from
Sep 20, 2024

Conversation

sjproctor
Copy link
Collaborator

This commit improves communication of intent by removing the multiple indicator from the hyku_indexing module.

Ref:

@sjproctor
💄 Removes the multiple indicator from indexing
8e7e988 
This commit improves communication of intent by removing the multiple
indicator from the hyku_indexing module.

Ref:
- scientist-softserv/adventist_knapsack#185
@sjproctor sjproctor added the patch-ver for release notes label Sep 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Test Results

    3 files  ±0      3 suites  ±0   17m 40s ⏱️ -17s
2 037 tests ±0  1 987 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 064 runs  ±0  2 012 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit e014d1f. ± Comparison against base commit b193a39.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. 
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 7589a9aa-dbc1-45ad-b7fb-2fd09cd887d7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit cfafe75b-b4df-4958-a6f2-372cfbebc402
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read c644f417-188c-431f-98d0-b90bab791ee0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 77f0a6fc-69d3-4f49-890e-9f112d4a94ef
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 907575fe-45a1-419c-be1a-c8f962df48ce
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 9ee33cc3-ac40-4c7e-b005-0646321d2ec3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 0d209b81-755c-4e67-86f5-6c915f1515f2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 2573d5cf-4279-4c30-8171-2c25d721ff35
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy ff26d658-83d7-4e2c-8e28-2d174dd73dbf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit f62e6e64-5ac6-4422-8185-350490894861
…

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 5f9acb38-c878-41ea-8ca1-68d1d7e0a539
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit fe34b594-a396-46a8-9101-de1c30605692
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 1226b4bc-0a1e-4576-bb87-4fdb4e3cfdfd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 574cea2a-b886-4e7b-af10-ffa1cfa07ce9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy d03dcb4f-97a1-4c6a-92c0-3a846cffef79
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit d9739cbd-0907-45f7-8367-5d8af50bbd2a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 1ef037aa-2a8a-4532-8d2c-5993337f74b5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 8db253fa-1997-4abc-a773-709706ac1c1f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy d7683bf6-c121-4f72-a6d3-c14fcd46a4b6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit b5744597-4856-424f-8ef8-cfe5df1b6ccf
…

♻️ This comment has been updated with latest results.

@ShanaLMoore
Copy link
Collaborator

I'm hving a change of heart about this. Won't it be a problem if the data in prod is multiple, but when we convert it to valkyrie we're asking it to be single? will we lose data that way? cc @sjproctor

I think we need to match how the index properties are defined in prod.

@ShanaLMoore ShanaLMoore mentioned this pull request Sep 20, 2024
Closed
29 tasks
@ShanaLMoore
Copy link
Collaborator

Please work with @kirkkwang to resolve this issue

@ShanaLMoore ShanaLMoore marked this pull request as draft September 20, 2024 20:15
@sjproctor
🐛 Updates Solr names to sort on singular items
e014d1f 
This commit improves communication of intent by removing the multiple
indicator from the hyku_indexing module in the catalog_controller.

Ref:
- scientist-softserv/adventist_knapsack#185
@sjproctor sjproctor changed the title 💄 Removes the multiple indicator from indexing 💄 Removes the multiple indicator from Solr suffix Sep 20, 2024
@sjproctor sjproctor marked this pull request as ready for review September 20, 2024 22:19
@sjproctor sjproctor merged commit d6892bf into main Sep 20, 2024
8 checks passed
@sjproctor sjproctor deleted the index-search-on-singular-items branch September 20, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkkwang kirkkwang kirkkwang approved these changes

Assignees
No one assigned
Labels
patch-ver for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjproctor @ShanaLMoore @kirkkwang